🔁 Upgrade to Solidity Version 0.8.21

[pcaversaccio]

• Official Release: https://github.com/ethereum/solidity/releases/tag/v0.8.21
• We should use the feature that you can now access events from other contracts for our Foundry tests:
  

[pcaversaccio]

It looks like emitting events from other contracts is currently not possible due to an ICE: ethereum/solidity#14430

[nikola-matic]

It looks like emitting events from other contracts is currently not possible due to an ICE: ethereum/solidity#14430

Emitting events from other contracts itself works just fine; requesting --userdoc or --devdoc when you have such events is what causes the ICE. Hope that helps.

[pcaversaccio]

Emitting events from other contracts itself works just fine; requesting --userdoc or --devdoc when you have such events is what causes the ICE. Hope that helps.

I'm having a hard time to make a contract compile however; let's take the following contract (Test.sol):

// SPDX-License-Identifier: MIT
pragma solidity 0.8.21;

contract X {
    event E();
}

contract C {
    function g() public {
        emit X.E();
    }
}

Now invoking something like solc --asm .\Test.sol (not requesting userdoc nor devdoc), will still throw:

Internal compiler error:
C:\Users\circleci\project\libsolidity\interface\Natspec.cpp(89): Throw in function class Json::Value __cdecl solidity::frontend::Natspec::userDocumentation(const class solidity::frontend::ContractDefinition &)
Dynamic exception type: struct boost::wrapexcept<struct solidity::langutil::InternalCompilerError>
std::exception::what: Solidity assertion failed
[struct solidity::util::tag_comment * __ptr64] = Solidity assertion failed

Can you elaborate on what am doing wrong? Version: Version: 0.8.21+commit.d9974bed.Windows.msvc

[nikola-matic]

Emitting events from other contracts itself works just fine; requesting --userdoc or --devdoc when you have such events is what causes the ICE. Hope that helps.

I'm having a hard time to make a contract compile however; let's take the following contract (Test.sol):

// SPDX-License-Identifier: MIT
pragma solidity 0.8.21;

contract X {
    event E();
}

contract C {
    function g() public {
        emit X.E();
    }
}

Now invoking something like solc --asm .\Test.sol (not requesting userdoc nor devdoc), will still throw:

Internal compiler error:
C:\Users\circleci\project\libsolidity\interface\Natspec.cpp(89): Throw in function class Json::Value __cdecl solidity::frontend::Natspec::userDocumentation(const class solidity::frontend::ContractDefinition &)
Dynamic exception type: struct boost::wrapexcept<struct solidity::langutil::InternalCompilerError>
std::exception::what: Solidity assertion failed
[struct solidity::util::tag_comment * __ptr64] = Solidity assertion failed

Can you elaborate on what am doing wrong? Version: Version: 0.8.21+commit.d9974bed.Windows.msvc

In that case nothing - essentially, any steps that require userdoc or devdoc (asm, metadata, etc.) will indeed fail - I was just commenting in case you just read the issue and didn't try to compile anything. I guess you'll have to wait for the 0.8.22 release like most everyone else :)