Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with recent nightly 6.99 #6

Open
Robyrob opened this issue Aug 16, 2022 · 12 comments
Open

Not working with recent nightly 6.99 #6

Robyrob opened this issue Aug 16, 2022 · 12 comments

Comments

@Robyrob
Copy link

Robyrob commented Aug 16, 2022

Using it with recent nightly release, it stop working.
I think because kicad programmer changed the option "SetExcludeEdgeLayer()

@pcbway
Copy link
Owner

pcbway commented Aug 16, 2022

Hi,I didn't get the meaning.
We just tried,it is workig well.
Could you tell me the details?

@Robyrob
Copy link
Author

Robyrob commented Aug 16, 2022

I am using the nightly version of Kicad:
Version: (6.99.0-2815-gbbc0c61ccb), release build in Windows 64
In stable version of kicad 6.0 Your plugin is working; in nightly version it doesn't work. The procession bar stop and the files are not generated.
In the python console the message is:'PCB_PLOT_PARAMS' object has no attribute 'SetExcludeEdgeLayer'

@pcbway
Copy link
Owner

pcbway commented Aug 16, 2022

Thanks,I will contact with KiCAD team about this.

@sethhillbrand
Copy link

The line

        popt.SetExcludeEdgeLayer(True)

Should be

        if hasattr(popt, "SetExcludeEdgeLayer"):
            popt.SetExcludeEdgeLayer(True)

@pcbway
Copy link
Owner

pcbway commented Nov 3, 2022

Thansk for the help,last time we didn't find the way out

@greggjaskiewicz
Copy link

it doesn't work wth the 7.0rc1 still. Please make sure it does, because many of us are using it and trying to push designs using this plugin.

@jonaslee228
Copy link

Yes I agree. It is very unhandy to have this not working. Please fix it soon.

@subst4nc3
Copy link

subst4nc3 commented Jan 26, 2023

KEEP IN MIND THAT I'M NOT A PROGRAMMER....
so the modification are proposed without any warranty and i'm not responsible if you receive an incorrect board made with these modifications.

Hello, i have managed to make it working again by changing and adding some lines in the thread.py file, according to the changes made to another similiar plugin (AISLER):

modify (as suggest by sethhillbrand) from:
popt.SetExcludeEdgeLayer(True)
to:

    if hasattr(popt, "SetExcludeEdgeLayer"):
        popt.SetExcludeEdgeLayer(True)

modify from:
boardWidth = pcbnew.Iu2Millimeter(board.GetBoardEdgesBoundingBox().GetWidth())
boardHeight = pcbnew.Iu2Millimeter(board.GetBoardEdgesBoundingBox().GetHeight())
to:
boardWidth = pcbnew.ToMM(board.GetBoardEdgesBoundingBox().GetWidth())
boardHeight = pcbnew.ToMM(board.GetBoardEdgesBoundingBox().GetHeight())

----add:
angle = f.GetOrientation()
try: # kicad >= 6.99
angle = angle.AsDegrees()
except AttributeError: # kicad <7
angle /= 10.0
---before components.append({ statement.

modify from:
'rotation': f.GetOrientation() / 10.0,
to:
'rotation': angle,

@pcbway
Copy link
Owner

pcbway commented Feb 15, 2023

Now we have solved the problem and updated the plugin that suitable for version7

@greggjaskiewicz
Copy link

still not available in Kicad itself tho.

@KanyonKris
Copy link

Version 0.1.3 works for me in KiCad 7. Downloaded the plugin and installed manually. I assume version 0.1.3 will be added to the official KiCad plugin repository eventually.

@pcbway
Copy link
Owner

pcbway commented Feb 16, 2023

We will add to the official KiCad plugin repository in gitlab soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants