-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying the full commit message #274
Comments
The current specification is for using GitHub's ability to display commit hash information like the following. Is there a problem with including a commit hash that fired a deployment in a commit message? Can you explain the problem in detail? If we add that new feature, I'm going to implement it in the following way. - uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
full_commit_message: ${{ github.event.head_commit.message }} |
I am including the hash myself, except it is not at the end and it uses # steps:
- id: rev
run: echo ::set-output name=rev::$(git rev-parse --short HEAD)
- uses: peaceiris/actions-gh-pages@v3
with:
commit_message: Docs for ${{ steps.rev.outputs.rev }}: ${{ github.event.head_commit.message }} |
* feat: Add full_commit_message * ci: Add full_commit_message * docs: Add full_commit_message cf. #274
* feat: Add full_commit_message * ci: Add full_commit_message * docs: Add full_commit_message cf. #274
Thank you, this is perfect. I appreciate the quick fix. |
I am interested in using this Action, but I'd like to have complete control of the commit message of the resulting commit. The
commit_message
input described in https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-set-custom-commit-message allows setting a prefix of the commit message but the following code subsequently unconditionally appends the 40-character commit hash from the source commit onto that:actions-gh-pages/src/git-utils.ts
Lines 148 to 154 in 750c807
Would it be possible to expose control over the full message in a way that disables appending that hash?
Tentative proposal that would work for my use case, but open to others:
The text was updated successfully, but these errors were encountered: