Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false partial matches #394

Merged
merged 4 commits into from
Jul 14, 2020
Merged

fix false partial matches #394

merged 4 commits into from
Jul 14, 2020

Conversation

zachbryant
Copy link
Contributor

@zachbryant zachbryant commented Jul 13, 2020

Ensure that the publish branch is treated as a complete name and not as a prefix.

@zachbryant zachbryant requested a review from peaceiris as a code owner July 13, 2020 22:49
@peaceiris peaceiris linked an issue Jul 13, 2020 that may be closed by this pull request
@peaceiris
Copy link
Owner

Thank you very much! I will add some tests.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   58.09%   58.09%           
=======================================
  Files           4        4           
  Lines         241      241           
  Branches       43       43           
=======================================
  Hits          140      140           
  Misses        101      101           
Impacted Files Coverage Δ
src/set-tokens.ts 42.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b76e36...ed89395. Read the comment docs.

@peaceiris peaceiris merged commit f53ab0c into peaceiris:master Jul 14, 2020
peaceiris added a commit that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prohibited branch incorrect detection
2 participants