fix: Array and string offset access syntax with curly braces is no longer supported #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a first step toward support for PHP 8. AFAIK, with this PR, the code will run on PHP 8 but the test suite need to be updated to PHP Unit 8 (#12 is a first step for that). |
|
Any thought ? |
|
Bump. |
|
Please merge this because of PHP8 compatibility. Thanks a lot. |
CloCkWeRX
approved these changes
Mar 27, 2022
|
Thanks for merging this. |
This was referenced Apr 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #10: it fixes the syntax for array access for recent versions of PHP in class
HTML_Template_ITX.