Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the test suite to PHP 8 #15

Closed
wants to merge 6 commits into from
Closed

Conversation

duboism
Copy link
Contributor

@duboism duboism commented Jul 22, 2024

This PR follows #11 and #12. Here we port the test suite to PHP 8. This requires PHP Unit >= 9.3 which requires to drop support for PHP 5.6.

@duboism duboism mentioned this pull request Jul 22, 2024
@duboism
Copy link
Contributor Author

duboism commented Jul 22, 2024

Travis CI no longer works so I manually tested PHP 7.4 to PHP 8.3.0 and it seems that the test suite can be installed on all those versions and all the test pass.

@duboism duboism marked this pull request as ready for review July 22, 2024 21:19
@Neustradamus
Copy link

@duboism: Thanks, nice to see your PR!

Can you add "Issues" section in this repository, it is not by default.

@duboism
Copy link
Contributor Author

duboism commented Aug 18, 2024

@Neustradamus, sorry for the late answer. I don't have enough privileges to do that, sorry. You should probably contact the PEAR team. As far as I know, there is no such team on GitHub so the only way I know is to use the mailing list at https://pear.php.net/support/lists.php. If you find another way, please tell me.

@Neustradamus
Copy link

@ashnazg: Can you add "Issues" section?

@duboism has said that he can not do it himself.

Can you look the PR too?

Thanks in advance.

@duboism
Copy link
Contributor Author

duboism commented Aug 18, 2024

By the way, I think that there is a version conflict in the current code: for PHP >= 8.0, one needs PHP Unit >= 9.3 but this requires PHP >= 7.3 (see https://phpunit.de/supported-versions.html). So this PR would in fact mean to drop all support for PHP < 7.3.

I will try to see what's possible but in the meantime, we should not merge this.

@duboism
Copy link
Contributor Author

duboism commented Sep 2, 2024

I think it's better to merge #16 before merging this (see the discussion there).

@duboism
Copy link
Contributor Author

duboism commented Sep 2, 2024

For this PR, I did some experiments with PHPUnit Polyfills, a library that provides an homogeneous API for a lot of PHPUnit versions with very few code change. It's recommended on PHPUnit home page so I think it's a robust solution. With this, I think I can make the test work from 5.6 up to 8.3.

@duboism
Copy link
Contributor Author

duboism commented Sep 13, 2024

For this PR, I did some experiments with PHPUnit Polyfills, a library that provides an homogeneous API for a lot of PHPUnit versions with very few code change. It's recommended on PHPUnit home page so I think it's a robust solution. With this, I think I can make the test work from 5.6 up to 8.3.

I opened PR #17 to implement the changes described above. Therefore I will close this PR.

@duboism duboism closed this Sep 13, 2024
@duboism duboism deleted the use_php_7_above branch November 24, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants