Support for PHP 7.2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2018 22:26
each function is deprecated in PHP7.2.0. refs: http://php.net/manual/en/migration72.deprecated.php
|
Aww... 😭 To use PHPUnit without each function, I upgraded to PHPUnit 5.7.9 but It doesn't run less than PHP 5.6... Problem 1
- phpunit/phpunit 5.7.9 requires php ^5.6 || ^7.0 -> your PHP version (5.4.45) does not satisfy that requirement. |
|
HTML_Template_IT requires PHP 5.4 at least, PHPUnit has to be downgraded to version 4. |
added 3 commits
February 28, 2018 01:35
hypermkt
force-pushed
the
support-php7.2
branch
from
5f450ef to
d858f74
Compare
|
Oh, It's passed successfully on CI finally! 🎉 |
|
@ashnazg Could you please review this PR? |
ashnazg
approved these changes
Feb 27, 2018
|
Thanks you for merging. I hope it's also released on pear. |
wernerwa
pushed a commit
to wernerwa/HTML_Template_IT
that referenced
this pull request
Mar 28, 2019
Support for PHP 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.1 was supported by this PR ( #2 ). But CI was failing on PHP 7.2 because of using deprecated each function on PHP 7.2.0.
So I fixed the problem by removing each function.
References