Fix strncmp size argument in WebDav/Server.php #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where a
strncmp($key, "HTTP_CONTENT", 11)
is called with an off-by-one size parameter, as the"HTTP_CONTENT"
string length (without the null byte) is 12 and not 11.There is not much impact here - if someone sends a header
ContenX
whereX
can be any char other than'T'
the program will go to thedefault:
branch and write out that this key is not supported: