-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: core: 1st party sql parser using winnow combinators #371
Open
jussisaurio
wants to merge
18
commits into
main
Choose a base branch
from
sql-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jussisaurio
changed the title
wip sql parser using winnow combinators
core: 1st party sql parser using winnow combinators
Oct 21, 2024
jussisaurio
changed the title
core: 1st party sql parser using winnow combinators
RFC: core: 1st party sql parser using winnow combinators
Oct 21, 2024
@jussisaurio Rolling out a parser by hand is going to be very hard to make compatible with SQLite. If you want more control over AST generation, a better path is likely porting https://github.com/gwenn/lemon-rs over to our source tree. We can merge this parser too if you want to pursue it, but it needs to be under a feature flag and disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimenting with building a 1st party sql parser. not integrated to the main limbo codebase yet, lives independently inside
core/parser
. this is not generated from any grammar - it uses the winnow parser combinator library for the tokenizer and handcrafted imperative parsing for the parser.the main advantages of this are:
sqlite3_parser
provided AST. For example, not being able to annotate that "this Expr is a column from a known table in our catalog, and it is column number 3", or saying "this expression is a projection made on the result column number 4 of the Sort operator with id 'sorter_foo'"sqlite3_parser
. Latestbench
stats from CI:Please note that the results are probably at least in part explained by our inhouse parser not supporting the full SQL syntax yet.
the main disadvantages are:
Only SELECT related syntax supported right now.
SELECT Statement
Operators and Expressions
JOINs
Data Types and Literals
Functions
Additional Features
Other SQL Statement Types