Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font IDs guide improvements #240

Closed
sylbru opened this issue Nov 28, 2024 · 0 comments · Fixed by #243
Closed

Font IDs guide improvements #240

sylbru opened this issue Nov 28, 2024 · 0 comments · Fixed by #243

Comments

@sylbru
Copy link

sylbru commented Nov 28, 2024

The step-by-step guide for finding font IDs has two issues that make it, I think, less clear that it should be:

  • "Step 4 : Locate the Font ID" doesn’t say which specific kind of element to look for, whereas it should say (I think) that we’re looking for a style element with an id like custom-… (containing @font-faces etc.) (the ID shape is mentioned in the next step but feels at least as relevant in this one)
  • In my case the UI was asking for three IDs, three variants of the same font. I could only find one font ID (one style block) for all variants of the font, so I used the same ID in all three inputs. Not sure if that’s expected as the guide didn’t mention that.
  • In my case, there are a few more variants, and one more font, than those listed in the dialog that’s asking for font IDs, so it’s a bit confusing, and nothing seems to clear that up.

Sorry if that’s a bit of vague/composite issue, let me know if you want me to split that in several issues.

@Cenadros Cenadros linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant