feat: Support static snapshots in .percy.yml configuration file
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maprules1000
changed the title
maprules1000
commented
Apr 17, 2019
src/utils/configuration.ts
Outdated
| @@ -22,7 +29,9 @@ const configuration = (relativePath = '.percy.yml'): Configuration => { | |||
| // in a chain. snapshot specific options -> agent configuration -> default values | |||
|
|
|||
| const defaultConfiguration: Configuration = { | |||
| version: 1.0, snapshot: {}, | |||
| version: 1.0, | |||
There was a problem hiding this comment.
Should this version be updated since it introduces static_site? It is still 100% compatible with the existing format
maprules1000
changed the title
maprules1000
force-pushed
the
map/static-snapshop-options-yml-file
branch
from
ca7fc2b
to
7a07c6d
Compare
djones
changed the title
djones
changed the title
Robdel12
force-pushed
the
map/static-snapshop-options-yml-file
branch
from
5019d9c
to
1faf252
Compare
Robdel12
reviewed
May 14, 2019
| @@ -2,3 +2,7 @@ version: 1 | |||
| snapshot: | |||
| widths: [375, 1280] | |||
| min-height: 1024 | |||
There was a problem hiding this comment.
Pre-existing, but interesting this is not camel cased.
src/utils/configuration.ts
Outdated
| @@ -22,7 +29,9 @@ const configuration = (relativePath = '.percy.yml'): Configuration => { | |||
| // in a chain. snapshot specific options -> agent configuration -> default values | |||
|
|
|||
| const defaultConfiguration: Configuration = { | |||
| version: 1.0, snapshot: {}, | |||
| version: 1.0, | |||
fotinakis
reviewed
May 28, 2019
djones
reviewed
Jun 5, 2019
| @@ -22,11 +29,12 @@ const configuration = (relativePath = '.percy.yml'): Configuration => { | |||
| // in a chain. snapshot specific options -> agent configuration -> default values | |||
|
|
|||
| const defaultConfiguration: Configuration = { | |||
| version: 1.0, snapshot: {}, | |||
| 'version': 1.0, | |||
There was a problem hiding this comment.
this should stay as 1.0. These new options are completely compatible with the current configuration. We don't actually have any configuration version handling in place, this was just added for future proofing if we do find ourselves with breaking changes.
…ous configuration interfaces into multiple files
djones
changed the title
.percy.yml configuration file
djones
pushed a commit
that referenced
this pull request
Jun 6, 2019
# [0.6.0](v0.5.3...v0.6.0) (2019-06-06) ### Features * Support static snapshots in `.percy.yml` configuration file ([#159](#159)) ([d9e5efe](d9e5efe))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the static snapshot flags to the percy.yml file.
Since each flag has a default, the preference is to look for the yml file setting, and fall back to the flags passed in through the command line. Otherwise the defaults will always be used and the percy.yml settings will never be picked up.