fix: Reject redirected requests for static snapshots #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so we no longer get redirected from the URL we visit to another one. That usually results in an error, which fails the test suite. This also adds some try/catches around parts of the snapshot that could fail with helpful error messages
Robdel12
commented
Jul 3, 2019
| return percyAgentClient.snapshot(snapshotName) | ||
| }, url) | ||
| try { | ||
| await page.goto(url, { waitUntil: 'networkidle2' }) |
There was a problem hiding this comment.
networkidle2 is much faster than networkidle0
djones
pushed a commit
that referenced
this pull request
Jul 3, 2019
## [0.8.3](v0.8.2...v0.8.3) (2019-07-03) ### Bug Fixes * Reject redirected requests for static snapshots ([#273](#273)) ([a75a445](a75a445))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This makes it so we no longer get redirected from the URL we visit to another one. That usually results in an error, which fails the test suite.
This also adds some try/catches around parts of the snapshot that could fail with helpful error messages