fix: Prevent writing to the snapshot log once the resource sha is created #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the log contents change, the resource sha will no longer match the content sha and the API will throw errors
wwilsman
force-pushed
the
ww/scale-back-captured-logs
branch
from
93bc6e7
to
0d8c904
Compare
djones
pushed a commit
that referenced
this pull request
Sep 12, 2019
## [0.12.1](v0.12.0...v0.12.1) (2019-09-12) ### Bug Fixes * Prevent writing to the snapshot log once the resource sha is created ([#345](#345)) ([2a46561](2a46561))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If the log contents change, the resource sha will no longer match the content sha and the API will throw errors.
Approach
Copy the log file upon sha creation and upload that copied file. This way, the original log can still be written to, but the copy won't.