fix: Restrict try-catch in upload command so build can be finalized #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than try-catching the entire method, the try-catch can be wrapped around only the section between creating and finalizing a build. The try-catch is used instead of chaining a `.catch` onto the promise in case the `reduce` callback throws during argument evaluation.
djones
pushed a commit
that referenced
this pull request
Oct 3, 2019
## [0.18.1](v0.18.0...v0.18.1) (2019-10-03) ### Bug Fixes * Restrict try-catch in upload command so build can be finalized ([#387](#387)) ([eed8798](eed8798))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During image upload, If an error occurs after starting a build, but before finalizing, the build will get stuck waiting for snapshots.
Approach
Rather than try-catching the entire method, the try-catch can be wrapped around only the section between creating and finalizing a build. The try-catch is used instead of chaining a
.catchonto the promise in case thereducecallback throws during argument evaluation.