feat: Capture Canvas elements #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now capture Canvas elements and serialize them into images in the DOM snapshot we capture. Important to note WebGL canvas elements will need to enable `preserveDrawingBuffer` in order for us to capture them.
wwilsman
suggested changes
Mar 13, 2020
wwilsman
reviewed
Mar 13, 2020
wwilsman
reviewed
Mar 13, 2020
djones
pushed a commit
that referenced
this pull request
Mar 13, 2020
# [0.25.0](v0.24.3...v0.25.0) (2020-03-13) ### Features * Capture Canvas elements ([#483](#483)) ([7b45c12](7b45c12))
Turbo87
added a commit
to Turbo87/skylines
that referenced
this pull request
Aug 9, 2020
percy/percy-agent#483 is giving us troubles because of https://github.com/percy/percy-agent/issues/550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
We can now capture Canvas elements and serialize them into images in the DOM snapshot we capture.
Important to note WebGL canvas elements will need to enable
preserveDrawingBufferin order for us to capture them.TODOs
preserveDrawingBufferis needed? Recipe?