fix: Ignore any protocols that aren't http or https
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
force-pushed
the
rd/skip-non-http-https-resources
branch
from
93979e3
to
4fd4edd
Compare
wwilsman
reviewed
May 14, 2020
The API will throw an error anyways, so we shouldn't bother trying to create resources or snapshots with non `http` or `https` protocols.
Robdel12
force-pushed
the
rd/skip-non-http-https-resources
branch
from
4fd4edd
to
43e91b1
Compare
djones
pushed a commit
that referenced
this pull request
May 14, 2020
## [0.26.3](v0.26.2...v0.26.3) (2020-05-14) ### Bug Fixes * Ignore any protocols that aren't `http` or `https` ([#507](#507)) ([8a121b6](8a121b6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
The API will throw an error anyways, so we shouldn't bother trying to create resources or snapshots with non
httporhttpsprotocols.