fix: Capture assets using the same hostname, regardless of port #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if someone is serving their app from `localhost:3001` and then serves their assets from `localhost:3002`, we will skip the assets coming from `localhost:3002`. This is because we're taking the port into account for asset discovery right now. This change removes the port from consideration and captures all assets based on the `hostname` rather than `host`.
djones
pushed a commit
that referenced
this pull request
Jul 17, 2020
## [0.27.1](v0.27.0...v0.27.1) (2020-07-17) ### Bug Fixes * Capture assets using the same hostname, regardless of port ([#535](#535)) ([d490fa9](d490fa9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Currently, if someone is serving their app from
localhost:3001and then serves their assets fromlocalhost:3002, we will skip the assets coming fromlocalhost:3002. This is because we're taking the port into account for asset discovery right now.This change removes the port from consideration and captures all assets based on the
hostnamerather thanhost.