Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add healthcheck command #122

Merged
merged 4 commits into from
Apr 3, 2019
Merged

feat: Add healthcheck command #122

merged 4 commits into from
Apr 3, 2019

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Apr 3, 2019

What is this?

In some instances it's helpful to have a CLI command that runs a check to make sure the Percy process is running. This will be especially helpful in the Cypress SDK where we're having struggles with providing a nice way to run a CLI command with the SDK:

Usage

$ percy health-check or $ percy health-check -p 5502

Robdel12 added 3 commits April 3, 2019 15:16
This should fix the following error in CI:

```
error computing cache key: template: cacheKey:1:47: executing "cacheKey" at <checksum "yarn.lock">: error calling checksum: open /home/circleci/cli/yarn.lock: no such file or directory
```

This is because we don't actually have a yarn lock file
@Robdel12 Robdel12 requested a review from djones April 3, 2019 21:03
@Robdel12
Copy link
Contributor Author

Robdel12 commented Apr 3, 2019

I'll probably have to rebase this after #121 & maybe #120

src/commands/health-check.ts Outdated Show resolved Hide resolved
src/commands/health-check.ts Outdated Show resolved Hide resolved
@@ -12,7 +12,7 @@ jobs:
- checkout
- restore_cache: &restore_cache
keys:
- v1-yarn-{{checksum ".circleci/config.yml"}}-{{ checksum "yarn.lock"}}
- v1-yarn-{{checksum ".circleci/config.yml"}}-{{ checksum "package-lock.json"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Copy link
Contributor

@djones djones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM. Great stuff @Robdel12

@Robdel12 Robdel12 merged commit 5560d6a into master Apr 3, 2019
@Robdel12 Robdel12 deleted the rd/healthcheck-command branch April 3, 2019 22:21
djones pushed a commit that referenced this pull request Apr 3, 2019
# [0.2.0](v0.1.18...v0.2.0) (2019-04-03)

### Features

* Add `healthcheck` command ([#122](#122)) ([5560d6a](5560d6a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants