-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add healthcheck
command
#122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the following error in CI: ``` error computing cache key: template: cacheKey:1:47: executing "cacheKey" at <checksum "yarn.lock">: error calling checksum: open /home/circleci/cli/yarn.lock: no such file or directory ``` This is because we don't actually have a yarn lock file
djones
reviewed
Apr 3, 2019
djones
reviewed
Apr 3, 2019
djones
reviewed
Apr 3, 2019
@@ -12,7 +12,7 @@ jobs: | |||
- checkout | |||
- restore_cache: &restore_cache | |||
keys: | |||
- v1-yarn-{{checksum ".circleci/config.yml"}}-{{ checksum "yarn.lock"}} | |||
- v1-yarn-{{checksum ".circleci/config.yml"}}-{{ checksum "package-lock.json"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
djones
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍍 LGTM. Great stuff @Robdel12
djones
pushed a commit
that referenced
this pull request
Apr 3, 2019
# [0.2.0](v0.1.18...v0.2.0) (2019-04-03) ### Features * Add `healthcheck` command ([#122](#122)) ([5560d6a](5560d6a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
In some instances it's helpful to have a CLI command that runs a check to make sure the Percy process is running. This will be especially helpful in the Cypress SDK where we're having struggles with providing a nice way to run a CLI command with the SDK:
dist
folder always percy-cypress#72Usage
$ percy health-check
or$ percy health-check -p 5502