Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairs has peek() but does not implement Peekable and has a different interface #920

Open
frp opened this issue Aug 26, 2023 · 0 comments
Open
Labels

Comments

@frp
Copy link

frp commented Aug 26, 2023

$SUBJ. This means that next_if and other things I came to expect from the iterators that have peek() are not available.

Also, Pairs::peek() returns Option<Pair<...>> instead of Option<&Pair<...>> like the standard library's Peekable::peek() does.

A concern with just fixing it is that it's a breaking API change. But maybe it would make sense to do this if you're planning a new major release at some point?

@frp frp added the bug label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant