Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Pest #974

Open
ekechinwokah opened this issue Feb 8, 2024 · 2 comments
Open

Async Pest #974

ekechinwokah opened this issue Feb 8, 2024 · 2 comments

Comments

@ekechinwokah
Copy link

Hi - made some changes to use pest in async, largely borrowed from this code discussed in a previous issue.

Is there any interest in merging into the master branch? Either way is fine but wanted to check.

@NoahTheDuke
Copy link
Member

It looks like the only changes is from alloc::rc::Rc to alloc::rc::Arc? I think that's a breaking change as the Rc usages are on public-facing apis (structs and functions), and I don't know that we can make such a change without a major version bump.

I wonder what kind of benchmark hits this results in. How much slower is Arc than Rc in Pest?

@ekechinwokah
Copy link
Author

Ah, got it. We haven't benchmarked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants