Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using group 0 with setLightState() #5

Closed
wants to merge 1 commit into from
Closed

Support using group 0 with setLightState() #5

wants to merge 1 commit into from

Conversation

drifkin
Copy link

@drifkin drifkin commented Jun 9, 2013

Currently, we can't use group 0 as a shortcut to set the light state of all lights at once.

For example the following would display an error:

api.setLightState("0", state, true).fail(displayError).done()

The error reads: Api Error: The group id '0' is not valid for this Hue Bridge.

This allow us to use setLightState() to modify all lights
@peter-murray
Copy link
Owner

Thanks for the pull request, but I had a major update to the library for version 0.2.0, which already removes this issue, by moving the group light status requests to a new setGroupLightState() rather than being mixed up in the setLightState() function.
The updated version of the library was publish in npmjs.org today, but it does unfortunately break the existing use of the library, but this was necessary to clean up the library to make it easier to support, the changes to users should be minor (i.e. mostly in the require calls).

@drifkin
Copy link
Author

drifkin commented Jun 15, 2013

Great, looking forward to trying the new version out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants