Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseuri Version not found #57

Closed
marcgille opened this issue Sep 15, 2015 · 6 comments
Closed

parseuri Version not found #57

marcgille opened this issue Sep 15, 2015 · 6 comments

Comments

@marcgille
Copy link

It seems from package.js that >=1.2.3-2 <1.3.0 is required whereas npm only provides up to 0.4.

@peter-murray
Copy link
Owner

There are two parseUri libraries, npm is case sensitive... https://www.npmjs.com/package/parseUri

@marcgille
Copy link
Author

Thanks for the swift response. There might still be an issue with that in my usage pattern, which is using it in an npm package X and in turn using X in a package Y. The installation of X into Y fails with

notarget No compatible version found: parseuri@'>=1.2.3-2 <1.3.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.0.1","0.0.2","0.0.3","0.0.4"]
npm ERR! notarget
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of 'node-hue-api'
npm ERR! notarget

which seems to indicate that npm itself is looking for the wrong parseu(U)ri.

This is just to let you know. I will investigate whether the issue is somewhere on my side or npm itself. But may be you also have ideas.

@marcgille
Copy link
Author

For completeness: This is an npm problem and has been discussed before (npm/npm#7933). As suggested in that issue, npm shrinkwrap does the trick for the scenario I have reported - which is an A > B > C closure as described in the article.

Still an obligation for the owners of parseUri and parseuri to sort things out - in particular as parseuri is used by such a popular package as socketio.

@peter-murray
Copy link
Owner

Based on your findings I have removed the dependency on parseUri, as it is really no longer necessary, it was only used to work around an issue with url.parse() a long time back.

The update is present in 93ca0b3 and will part of the next release of the library, but I would like to include a few more bug fixes in the next release.

@peter-murray
Copy link
Owner

Thanks for your efforts in getting to the bottom of the issue 👍

@peter-murray
Copy link
Owner

This is now available in release 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants