Skip to content
This repository has been archived by the owner on Jun 27, 2020. It is now read-only.

Too many open files #44

Closed
eskwayrd opened this issue Apr 12, 2018 · 2 comments
Closed

Too many open files #44

eskwayrd opened this issue Apr 12, 2018 · 2 comments
Assignees
@pgaskin
Labels
bug

Comments

@eskwayrd
Copy link
Contributor

When I run BookBrowser in a folder with 6,955 books, once the indexer reaches 561 books, I start seeing this error:

2018/04/12 07:54:13 [561/6955] Error indexing /HumbleBundle E-books/SF and Fantasy/thelivesoftao.epub: open /HumbleBundle E-books/SF and Fantasy/thelivesoftao.epub: too many open files

This continues until processing reaches 1885 books and the process crashes.

I haven't investigated fully, but it seems like book files aren't being closed soon enough.
@eskwayrd
Copy link
Contributor Author

It's not the book files themselves that are being held open too long, but the generated image thumbnails. Thumbnail filehandles need to be closed sooner than the end of all indexing operations.

I'll try to create a PR to fix this.

@pgaskin pgaskin self-assigned this Apr 12, 2018
@pgaskin pgaskin added the bug label Apr 12, 2018
@pgaskin
Copy link
Owner

pgaskin commented Apr 12, 2018

OK. That sounds about right. Thanks for reporting this issue!

For now, you can increase the ulimit for open files.

@eskwayrd eskwayrd mentioned this issue Apr 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pgaskin pgaskin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eskwayrd @pgaskin