Skip to content
This repository has been archived by the owner on Jun 27, 2020. It is now read-only.

Feature Request: Author Images #54

Open
zachjord opened this issue May 14, 2018 · 2 comments
Open

Feature Request: Author Images #54

zachjord opened this issue May 14, 2018 · 2 comments

Comments

@zachjord
Copy link

I would like a way to manually add author images. Maybe just have an "authors" folder where the name of the image file matches the author name embedded in the ebooks?

@zachjord zachjord changed the title Author Images Feature Request: Author Images May 14, 2018
@ghost
Copy link

ghost commented Aug 31, 2018

@zacjor Yeah both manual and automatic images for authors make sense.

@sblinch
Copy link
Contributor

sblinch commented Mar 15, 2019

@geek1011 have you given any consideration to how you'd like "persistent" data like this to be handled on the filesystem? I planned to implement support for fetching both author images and missing cover images from OpenLibrary (and other sources, pluggable in a manner similar to the ebook format plugins). But how would you want them stored on disk?

Would you be OK with creating subdirectories under the -tempdir path, for example, tempdir/covers/ for the album covers and thumbs, tempdir/authors/ for the author images and thumbs, tempdir/index/ for the index data, etc?

On a related note, sites like OpenLibrary usually implement rate limiting, so we wouldn't want the images to be blown away at exit and re-downloaded at every startup if the user passes -tempdir without creating it. What do you think about a -datadir option which creates the directory if it doesn't exist but NEVER deletes it on exit? Sort of a more permanent alternative to -tempdir. Thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants