Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surfacewater: Inconsistent methods to calculate covered area #38

Closed
philippkraft opened this issue May 9, 2018 · 0 comments
Closed
Assignees
Labels
C++ Need to change C++ files (.h, .cpp)
Milestone

Comments

@philippkraft
Copy link
Owner

At a number of places, cmf needs to now which fration of a cell is covered by surfacewater, eg. Shuttleworth-Wallace to route ground evaporation either from the surface water or the first layer.

The cmf::upslope::Cell::surface_water_coverage function uses the undocumented "cmf::upslope::Cell::surface_amplitude" value. The puddle depth of the surfacewater has a similar function and is much cleaner.

@philippkraft philippkraft added the C++ Need to change C++ files (.h, .cpp) label May 9, 2018
@philippkraft philippkraft self-assigned this May 9, 2018
@philippkraft philippkraft added this to the 1.4 milestone May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Need to change C++ files (.h, .cpp)
Projects
None yet
Development

No branches or pull requests

1 participant