Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmf.waterbalance_connection does not work proberly #44

Closed
richardneumann84 opened this issue Jun 25, 2018 · 3 comments
Closed

cmf.waterbalance_connection does not work proberly #44

richardneumann84 opened this issue Jun 25, 2018 · 3 comments
Assignees

Comments

@richardneumann84
Copy link

Hello,
waterbalance_connection is ignoring other defined outflux from left node.
(trying the online tutorial as in the linked code, the flux_s3_s5 does not match with its definition - due to ignoration by waterbalance_connection). I also tried to change the order of the flux definitions - didn't fix the issue yet.
I expected waterbalance_connection to do this: flux_s3_s4 = flux_s1_s3 + flux_s2_s3 - flux_s3_s5 (see tutorial).

waterbalance_tut_RN.zip

some things are strange with the tutorial for the waterbalance_connection, too:
I: in the online tutorial the initial volumes for s1 and s2 are missing
II:

flux_s1_to_s3 = [] flux_s2_to_s3 = [] #insert ','
flux_s3_to_s4 = [] flux_s3_to_s5 = [] #insert ','
plt.ylabel("Flux [m³/day]") plt.xlabel("Time [days]") #insert ','
@philippkraft philippkraft self-assigned this Jun 25, 2018
@philippkraft
Copy link
Owner

Sorry for the Waterbalance-Tutorial, it is a complete mess and needs reworking. The waterbalance connection has the effect to keep the change rate of a storage 0 and hence the volume stored remains constant. In your case, the storage S3 has the initial and by the WB-Con constant value of 0 m³, and hence the technical flux from S3 to S5 is also 0 m³/day (see API-DOC for TechnicalFlux).

@philippkraft
Copy link
Owner

I have opened a new documentation issue for this and close this one.

@richardneumann84
Copy link
Author

In order to gain fluxes like:
flux_s3_to_s4 = flux_s1_to_s3 + flux_s2_to_s3 - flux_s3_to_s5 (see tutorial)
and
flux_s3_to_s5 as defined
which also keeps s3 empty
I changed the order of definitions like shown in the linked code
waterbalance_tut_RN (2).zip
(the cmf.waterbalance_connection is here defined within the solver_loop.)
Do you see any problems with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants