Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded mochiweb code #5

Closed
philss opened this issue Jan 24, 2015 · 5 comments
Closed

Remove embedded mochiweb code #5

philss opened this issue Jan 24, 2015 · 5 comments

Comments

@philss
Copy link
Owner

philss commented Jan 24, 2015

This is low priority.

The idea is to remove mochiweb code from this codebase.

Solutions are:

  • use a hex package of mochiweb (current not available);
  • create a new HTML parser in Elixir and use as hex dependency.
@os6sense
Copy link

Might another solution be a hex community package? https://github.com/hexpm/community

@philss
Copy link
Owner Author

philss commented Feb 28, 2015

@os6sense Great idea! I didn't know about that! I will try the hex community approach. Thanks!

@philss
Copy link
Owner Author

philss commented Mar 26, 2015

@os6sense Thanks for the suggestion! The package is now published and the floki v0.1.1 is already using it.

@sntran
Copy link

sntran commented Oct 3, 2015

Sorry to bring back an old issue, but is there a reason that we need the whole mochiweb package? Looks like you only uses the HTML parser from mochiweb, and that module has only seen 1 commit (which was to update the license) since 2013.

Would it be simpler to just include that module in the codebase?

Or, write own parser.

@philss
Copy link
Owner Author

philss commented Oct 4, 2015

Hi @sntran,

Your question is valid. I moved out the whole mochiweb code because I didn't want to maintain that code in this repository. The main reason is because I don't know Erlang enough to understand what is going on inside that code. Or perhaps I don't know the mechanics of the HTML parser enough.

So that lead to your second suggestion, which is write my own parser: I really want to do this, but this will take some time. I think it will be alive before Floki reaches 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants