Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memcached.ini or change default value for memcached.sess_prefix #340

Closed
Yuxael opened this issue Apr 26, 2017 · 4 comments
Closed
Milestone

Comments

@Yuxael
Copy link

Yuxael commented Apr 26, 2017

Please update either memcached.ini or php_memcached.c

memcached.ini says:

; memcached session key prefix
; valid values are strings less than 219 bytes long
; the default value is "memc.sess.key."
memcached.sess_prefix = "memc.sess.key."

while in php_memcached.c there is:

MEMC_SESSION_INI_ENTRY("prefix", "memc.sess.", OnUpdateSessionPrefixString, prefix)

Personally I'd prefer if you updated the latter to:

MEMC_SESSION_INI_ENTRY("prefix", "memc.sess.key.", OnUpdateSessionPrefixString, prefix)

for compatibility reasons.

While this is not critical it can cause some headache in an environment with multiple PHP versions.

@sodabrew sodabrew added this to the 3.0.4 milestone Apr 30, 2017
@sodabrew
Copy link
Contributor

The default INI file explicitly sets the value to memc.sess.key but without a config file it's set to memc.sess., ouch. Someone without a config file will notice a change in hardcoded defaults 🎱 if I adjust the code to match the documentation.

@sodabrew
Copy link
Contributor

Ping @remicollet this issue will be more apparent since I merged #330, and will need to be addressed before I can release.

@rlanvin
Copy link

rlanvin commented Oct 10, 2017

While this is not critical it can cause some headache in an environment with multiple PHP versions.

I just encountered this bug (when working with a mix of PHP5 & PHP7), so yeah I can confirm this - while not critical, it definitely caused some confusion.

@remicollet
Copy link
Collaborator

@sodabrew I agree, memc.sess.key. everywhere seems better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants