Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GET_EXTENDED flag. Add/rename other missing/misnamed constants. #335

Merged
merged 2 commits into from
Apr 30, 2017

Conversation

TysonAndre
Copy link
Contributor

This PR isn't complete, some constants (e.g. Memcached::ON_*) are
still not documented.
It aims to fill in commonly used constants.

@sodabrew
Copy link
Contributor

Thanks! I'll keep an eye on this PR, let me know when you're ready for merge.

@sodabrew sodabrew added this to the 3.0.4 milestone Mar 14, 2017
@sodabrew
Copy link
Contributor

Nudge - anything else you want to add before this PR is ready to merge?

Tyson Andre and others added 2 commits April 23, 2017 15:45
This PR isn't complete, some constants (e.g. `Memcached::ON_*`) are
still not documented.
It aims to fill in commonly used constants.
@TysonAndre TysonAndre force-pushed the document-GET_EXTENDED branch from 86ae7a3 to f398c43 Compare April 23, 2017 22:59
@sodabrew
Copy link
Contributor

Thank you! Merging now. Please open a new PR if you have any follow-ups or corrections. I'm planning the 3.0.4 release for the coming week.

@sodabrew sodabrew merged commit c23ea26 into php-memcached-dev:master Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants