TypeSpecifier: Narrow (bool) $expr like $expr == true
#3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Sep 1, 2024
| public function getFilePath(): string|false; | ||
| } | ||
|
|
||
| function bug7685(Reader $reader): void { |
There was a problem hiding this comment.
Extremely cool! But please follow the usual convention for regression tests - one file per issue, with bug-xxx.php filename and namespace. I'm used to look for them in this format.
|
Thank you! |
This was referenced Sep 1, 2024
alexander-schranz
pushed a commit
to sulu/skeleton
that referenced
this pull request
Nov 19, 2024
…7. (#258) * Bump phpstan/phpstan to ^1.12 This includes a fix to issue phpstan/phpstan#7685 "Cast to (bool) on string|false !== false should end in non-empty-string" * Remove @phpstan-ignore-next-line from config/router.php Since phpstan v1.12.1 the related issue is fixed. phpstan/phpstan#7685 phpstan/phpstan-src#3380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#8881
closes phpstan/phpstan#7685
closes phpstan/phpstan#6006
closes phpstan/phpstan#10528