Remove deprecated queries option in query()
#272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Jan 13, 2024
| Returns: QueryResponse object which contains the list of the closest vectors as ScoredVector objects, | ||
| and namespace name. | ||
| """ | ||
|
|
||
| def _query_transform(item): |
jhamon
force-pushed
the
jhamon/remove-multiple-queries
branch
from
e50036e to
bf2224e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was an argument on the
query()method for passing multiple queries at once. This has long been deprecated in the API and SDK, so it's time to remove it.Solution
queriesoption to bothIndex#queryandIndexGRPC#query.querieskwargType of Change
Test Plan
Recently added integration test suite gives high confidence queries still work after this change.