Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange $v.services #159

Open
samir-gandhi opened this issue Jun 23, 2021 · 0 comments
Open

Rearrange $v.services #159

samir-gandhi opened this issue Jun 23, 2021 · 0 comments
Labels
enhancement New feature or request istio

Comments

@samir-gandhi
Copy link
Contributor

We can rearrange how we accept service definitions from values yaml to have more flexibility
The new solution should allow us to:

  1. set any number of annotations on any service
  2. add loadbalancer services as needed for folks that may want to expose ldaps
  3. optionally, prepare for istio virtual service and gateway instead of ingress.

Current:

  services:
    https:
      servicePort: 9999
      containerPort: 9999
      ingressPort: 443
      dataService: true
    clusterbind:
      servicePort: 7600
      containerPort: 7600
      clusterService: true
    clusterfail:
      servicePort: 7700
      containerPort: 7700
      clusterService: true
    clusterExternalDNSHostname:

Proposed:

  services:
    data:
      annotations: {}
      https:
        servicePort: 9999
        containerPort: 9999
        ingressPort: 443
    cluster: 
      annotations: {}
      clusterbind:
        servicePort: 7600
        containerPort: 7600
        clusterService: true
      clusterfail:
        servicePort: 7700
        containerPort: 7700
        clusterService: true
    loadbalancer:
      annotations: {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request istio
Projects
None yet
Development

No branches or pull requests

1 participant