Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance to SCIM 2 section 2.5 #105

Open
wwebers opened this issue Dec 7, 2018 · 2 comments
Open

Compliance to SCIM 2 section 2.5 #105

wwebers opened this issue Dec 7, 2018 · 2 comments

Comments

@wwebers
Copy link

wwebers commented Dec 7, 2018

The client SDK seem to incorrectly interprete section 2.5 of the core standard, which states:

When a resource is expressed in
JSON format, unassigned attributes, although they are defined in
schema, MAY be omitted for compactness.

This "MAY" expresses according to RFC2119 that the server implementation is allowed to either omit the attribute or to send an empty value.

However, when talking to servers which return empty attributes, e.g. empty "display" attributes, we get the infamous UnrecognizedPropertyException exception.

@braveulysses
Copy link
Collaborator

@wwebers, can you please provide an example of the problem? Without further information, it seems more likely that you're deserializing with a POJO that doesn't support a "display" field, hence the UnrecognizedPropertyException.

@wwebers
Copy link
Author

wwebers commented Apr 5, 2019

I'm running a pretty much straight forward request:

    public void getUser() {
        Filter filter = null;
        try {
            filter = Filter.eq("userName", "wwebers");
        } catch (BadRequestException e) {
            e.printStackTrace();
        }
        try {
            ListResponse<UserResource> response = scimService
                    .searchRequest("Users")
                    .filter(filter.toString())
                    .invoke(UserResource.class);
        } catch (ScimException e) {
            e.printStackTrace();
        }
    }

Will say I use the DTOs which are provided by the pingidenity framework. I guess it's also related to my other issue #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants