Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance improvement for consecutive client requests: #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

performance improvement for consecutive client requests: #142

wants to merge 1 commit into from

Conversation

gclayburg
Copy link

create, replace, search

This fix allows the client to reuse the underlying TCP stream and avoid creating
a new TCP connection for each request. The effect of this is
especially noticeable when the connection to the SCIM server is using TLS or has
significant latency.

Ok, I see that ping identity does not accept pull requests, but I suspect that you will want this fix. The performance impact is quite significant under the conditions listed in issue #141

Notes:

  • I have tested this with GET, PUT and POST operations. I have not tried it with PATCH requests, but I suspect there is probably a similar issue there that is not addressed by this PR.
  • After implementing the fix, I noticed that the test class EndpointTestCase will fail in unpredictable ways. However, it seems to me that this is somehow an artifact of how the test is constructed and not an issue with the fix in this PR itself. I can supply the test case I use to verify this if it helps.

Please be aware that Ping Identity does not accept third-party contributions at this time! Please see our contribution guidelines.

Does this close any currently open issues?

…
fixes #141

@gclayburg
performance improvement for consecutive client requests: create, repl…
4e3ff6f 
…ace, search

This fix allows the client to reuse the underlying TCP stream and avoid creating
a new TCP connection for each request.  The effect of this is
especially noticeable when the connection to the SCIM server is using TLS or has
 significant latency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance issue in scim2-sdk-client
1 participant
@gclayburg