Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with h3 #335

Closed
jolo-dev opened this issue May 7, 2024 · 4 comments · Fixed by pinojs/pino#1968
Closed

Broken with h3 #335

jolo-dev opened this issue May 7, 2024 · 4 comments · Fixed by pinojs/pino#1968

Comments

@jolo-dev
Copy link

jolo-dev commented May 7, 2024

It seems that it does not work with h3.

I have reproduced the error, and I followed the instructions from the docs

https://stackblitz.com/edit/github-9quron?file=app.ts

@mcollina
Copy link
Member

mcollina commented May 7, 2024

Thanks for reporting. Apparently h3 does not use a connect/express style of middleware, as you can see in https://h3.unjs.io/guide/app#registering-event-handlers.

Therefore, h3 is not supported by its module.

@mcollina mcollina closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
@jolo-dev
Copy link
Author

jolo-dev commented May 7, 2024

@mcollina thanks for the reply.
It also means then that we need to remove that from the documentation, right?
https://getpino.io/#/docs/web?id=pino-with-h3

@jsumners
Copy link
Member

jsumners commented May 7, 2024

It was added 2 years ago pinojs/pino#1385. Likely something has changed. A PR to remove or update it to a working example would be welcome.

@mcollina
Copy link
Member

mcollina commented May 7, 2024

Here is it: pinojs/pino#1968.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants