Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering the overhead - let's remove unit tests from npm package #1672

Closed
koresar opened this issue Mar 17, 2023 · 4 comments
Closed

Lowering the overhead - let's remove unit tests from npm package #1672

koresar opened this issue Mar 17, 2023 · 4 comments

Comments

@koresar
Copy link

koresar commented Mar 17, 2023

Hello

I was quite surprised to see that this package deliberately decided to publish unit tests to npm registry. See here: https://www.npmjs.com/package/pino?activeTab=code

I've never seen this before (except accidental publish). But in this project the test folder is included to the files of the package.json:

"test",

This mistake is dragging from the first most version of pino.
Would you agree to make this module tiny by removing a hundred of files, and shrink down the size of npm tarball by half?

I urge removing this test folder from being published to NPM. I'm ready to submit a PR if needed. It's literally a 1 line change (need to remove "test" from the package.json/files array).

@jsumners jsumners closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
@koresar
Copy link
Author

koresar commented Mar 21, 2023

Looks like I need to go rethink my DX experience when I publish my npm modules.

Thanks @jsumners for taking your time explaining.

@jsumners
Copy link
Member

Looks like I need to go rethink my DX experience when I publish my npm modules.

If you like. We don't pretend that everyone agrees with our philosophy. We suggest doing what you think is right for your own projects.

@koresar
Copy link
Author

koresar commented Mar 22, 2023

I typically do what is right for the npm package users (their DX). My DX goes right after theirs though.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants