-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowering the overhead - let's remove unit tests from npm package #1672
Comments
Looks like I need to go rethink my DX experience when I publish my npm modules. Thanks @jsumners for taking your time explaining. |
If you like. We don't pretend that everyone agrees with our philosophy. We suggest doing what you think is right for your own projects. |
I typically do what is right for the npm package users (their DX). My DX goes right after theirs though. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hello
I was quite surprised to see that this package deliberately decided to publish unit tests to npm registry. See here: https://www.npmjs.com/package/pino?activeTab=code
I've never seen this before (except accidental publish). But in this project the
test
folder is included to thefiles
of thepackage.json
:pino/package.json
Line 17 in 49a29bb
This mistake is dragging from the first most version of pino.
Would you agree to make this module tiny by removing a hundred of files, and shrink down the size of npm tarball by half?
I urge removing this
test
folder from being published to NPM. I'm ready to submit a PR if needed. It's literally a 1 line change (need to remove "test" from thepackage.json/files
array).The text was updated successfully, but these errors were encountered: