CustomLevels typing not being repassed to child

[matheusvellone]

When creating a child logger, looks like it isn't receiving all types from parent instance when the child method is called without any additional options, despite the call for custom levels being typed correctly.

I made a small code to reproduce the error here https://codesandbox.io/s/tender-river-42vrrt?file=/src/index.ts

But this is the code too, for a quick look

import pino from "pino";

const customLevels = {
  foo: 99
};

const logger = pino({
  customLevels
});

type Logger = typeof logger;
type LogLevels = pino.Level | keyof typeof customLevels;

const fn = (logger: Pick<Logger, LogLevels>) => {};

const child = logger.child({ name: "child" });
const child2 = logger.child({ name: "child" }, {}); // note extra {} here

fn(child); // missing foo typing
fn(child2);

child.foo("bar");
child2.foo("bar");

I tried adding a default type for this generic as a {} and it solved the problem. I suspect that the Options & ChildOptions ends in { ... } & undefined which evaluates to never 🤔

Not 100% sure if this is the expected solution, but I'd be happy to work on a PR

[mcollina]

Go for the PR, sounds like a bug in the types

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.