Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A broken link in readme.md #805

Closed
eduard-malakhov opened this issue Apr 1, 2020 · 7 comments
Closed

A broken link in readme.md #805

eduard-malakhov opened this issue Apr 1, 2020 · 7 comments

Comments

@eduard-malakhov
Copy link

The link 'Extreme Mode ⇗' in the main readme leads to https://github.com/pinojs/pino/blob/master/docs/extreme.md which does not exist.

@eduard-malakhov
Copy link
Author

The same in the docs: http://getpino.io/#/docs/extreme

@chaffeqa
Copy link

chaffeqa commented Apr 1, 2020

As a note, the changelog does not do a good job highlighting the deprecation of extreme mode... just to add on to this confusion

@mcollina
Copy link
Member

mcollina commented Apr 1, 2020

Would you like to issue a PR to solve all of this? Also some different text for the changelog.

Note that extreme mode is renamed in sync: false on pino.destination(). It's simpler and more coherent. There is nothing "extreme" in using "extreme mode" anymore.

@chaffeqa
Copy link

chaffeqa commented Apr 2, 2020

ha yeah i noticed that after reading the deprication in the server logs 😆

So the biggest gripe to me was that after reading the deprication, i went to http://getpino.io/ and it still had the section on extreme(), however now that looks like its 404'ing.

I'd love to do a PR, but frankly im not so sure I understanding the doc release cycle, since after going to the website, i looked at the Changelog, didnt see anything that stood out, and then finally looked at the source code which seemed to change the asynchronouse.md file... hence arriving at the final conclusion

@mcollina
Copy link
Member

mcollina commented Apr 3, 2020

The website only reflect master. There is no published doc (yet) for previous release lines.

@AleksandrSl
Copy link
Contributor

Will be fixed by #838 I think

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants