Add pino.multistream #1004
Merged
Add pino.multistream #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source code imported from https://github.com/pinojs/pino-multi-stream.
jsumners
reviewed
Apr 7, 2021
There was a problem hiding this comment.
I'm okay with this if you are. I rather liked it being a separate module because we cold say "it exists, but we do not recommend it" and get out of undesirable issues. But I can see that we are not going to be able to get rid of this feature, so bringing into core probably makes sense.
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: James Sumners <[email protected]>
|
@jsumners @davidmarkclements could you take a final look? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source code imported from https://github.com/pinojs/pino-multi-stream.
Following up from the introduction of #1003 and #937, I think we can include this in pino as well.
A user might like to send the data to a remote transport and also write the logs to disk.
I plan to make
pino.multistream()to be usable within a custom transport, so that we do not spawn up more than one thread.