Automatically flush the logs on exit in Node v14+ #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
approved these changes
Aug 18, 2021
| @@ -37,7 +37,9 @@ test('pino with no args log everything when calling process.exit(0)', async ({ n | |||
| not(actual.match(/world/), null) | |||
| }) | |||
|
|
|||
| test('sync false does not log everything when calling process.exit(0)', async ({ equal }) => { | |||
| const hasWeak = !!global.WeakRef | |||
There was a problem hiding this comment.
nit: I despise double inverses more than coercing checks.
There was a problem hiding this comment.
eh 🤷 all forms of boolean conversion are a bit shit. Boolean(WeakRef) is where you call a class without new to cast it. == is not good for obvious reasons, !~~ is too esoteric. I suppose you could use 'WeakRef' in global instead
davidmarkclements
approved these changes
Aug 18, 2021
jsumners
reviewed
Aug 19, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the main developer experience hurdle in using asynchronous logging: the use of
pino.final().Thanks to
on-exit-leak-freewe can automatically flush on exit without leaking event emitter listeners (in most cases).This uses the same mechanism I experimented with for
pino.transport().