Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional: Update API response status code #1576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Apr 10, 2024

I went over all explicit status code, and updated the obvious ones. It could potentially break some clients, so I don't feel strong to merge this PR. I do think this is something good to have.

@tylerwowen tylerwowen requested a review from a team as a code owner April 10, 2024 21:06
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Apr 10, 2024
@tylerwowen tylerwowen changed the title Optional: remapping status code Optional: Update API response status code Apr 10, 2024
2. remove client error
3. Remove teletraan internal exception
4. Fix environment bean validation

commit-id:3586ac2f
@tylerwowen tylerwowen force-pushed the spr/master/3586ac2f branch from c842a7d to 66056ef Compare April 10, 2024 21:33
@tylerwowen tylerwowen force-pushed the spr/master/21ffe0a7 branch from f4e1569 to e10cdaa Compare April 10, 2024 21:33
Base automatically changed from spr/master/3586ac2f to master April 18, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant