From 7d4346a304e6a3726686543b698cef63777cfeb3 Mon Sep 17 00:00:00 2001
From: Igor Kalinovskiy <jolly-good-fellow@yandex.ru>
Date: Sat, 9 Nov 2019 18:10:26 +1000
Subject: [PATCH 1/2] Add snapshot-test for `keyof` (Pick|Omit)ByValue(Exact)?

---
 src/__snapshots__/mapped-types.spec.ts.snap | 8 ++++++++
 src/mapped-types.spec.snap.ts               | 8 ++++++++
 src/mapped-types.spec.ts                    | 8 ++++++++
 3 files changed, 24 insertions(+)

diff --git a/src/__snapshots__/mapped-types.spec.ts.snap b/src/__snapshots__/mapped-types.spec.ts.snap
index 56598e5..0a4268e 100644
--- a/src/__snapshots__/mapped-types.spec.ts.snap
+++ b/src/__snapshots__/mapped-types.spec.ts.snap
@@ -147,6 +147,8 @@ exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, undefined>>() (
 
 exports[`OmitByValue testType<OmitByValue<T, string | boolean>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: T[Key] extends string | boolean ? never : Key; }[keyof T]>"`;
 
+exports[`OmitByValue testType<keyof OmitByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined"`;
+
 exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
 
 exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
@@ -155,6 +157,8 @@ exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, undef
 
 exports[`OmitByValueExact testType<OmitByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>"`;
 
+exports[`OmitByValueExact testType<keyof OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined"`;
+
 exports[`Optional testType<Optional<Props, 'age' | 'visible'>>({ name: 'Yolo' }) (type) should match snapshot 1`] = `"Optional<Props, \\"age\\" | \\"visible\\">"`;
 
 exports[`Optional testType<Optional<Props, 'age' | 'visible'>>({ name: 'Yolo', age: 99 }) (type) should match snapshot 1`] = `"Optional<Props, \\"age\\" | \\"visible\\">"`;
@@ -177,6 +181,8 @@ exports[`PickByValue testType<PickByValue<RequiredOptionalProps, undefined>>() (
 
 exports[`PickByValue testType<PickByValue<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: T[Key] extends number ? Key : never; }[keyof T]>"`;
 
+exports[`PickByValue testType<keyof PickByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\" | undefined"`;
+
 exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | undefined>"`;
 
 exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | undefined>"`;
@@ -185,6 +191,8 @@ exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, undef
 
 exports[`PickByValueExact testType<PickByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>"`;
 
+exports[`PickByValueExact testType<keyof PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\" | undefined"`;
+
 exports[`PromiseType testType<PromiseType<Promise<string>>>() (type) should match snapshot 1`] = `"string"`;
 
 exports[`ReadonlyKeys testType<ReadonlyKeys<ReadWriteProps>>() (type) should match snapshot 1`] = `"\\"a\\""`;
diff --git a/src/mapped-types.spec.snap.ts b/src/mapped-types.spec.snap.ts
index ab1f567..6e0aa20 100644
--- a/src/mapped-types.spec.snap.ts
+++ b/src/mapped-types.spec.snap.ts
@@ -148,6 +148,8 @@ type RequiredOptionalProps = {
   testType<PickByValue<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, undefined>
   testType<PickByValue<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap -> "req" | undefined
+  testType<keyof PickByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: T[Key] extends number ? Key : never; }[keyof T]>
@@ -163,6 +165,8 @@ type RequiredOptionalProps = {
   testType<PickByValueExact<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, undefined>
   testType<PickByValueExact<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap -> "req" | undefined
+  testType<keyof PickByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>
@@ -195,6 +199,8 @@ type RequiredOptionalProps = {
   testType<OmitByValue<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef" | undefined>
   testType<OmitByValue<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef" | undefined
+  testType<keyof OmitByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: T[Key] extends string | boolean ? never : Key; }[keyof T]>
@@ -210,6 +216,8 @@ type RequiredOptionalProps = {
   testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef" | undefined>
   testType<OmitByValueExact<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef" | undefined
+  testType<keyof OmitByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>
diff --git a/src/mapped-types.spec.ts b/src/mapped-types.spec.ts
index f828cde..a6de52c 100644
--- a/src/mapped-types.spec.ts
+++ b/src/mapped-types.spec.ts
@@ -148,6 +148,8 @@ type RequiredOptionalProps = {
   testType<PickByValue<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap
   testType<PickByValue<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap
+  testType<keyof PickByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap
@@ -163,6 +165,8 @@ type RequiredOptionalProps = {
   testType<PickByValueExact<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap
   testType<PickByValueExact<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap
+  testType<keyof PickByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap
@@ -195,6 +199,8 @@ type RequiredOptionalProps = {
   testType<OmitByValue<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap
   testType<OmitByValue<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap
+  testType<keyof OmitByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap
@@ -210,6 +216,8 @@ type RequiredOptionalProps = {
   testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>();
   // @dts-jest:pass:snap
   testType<OmitByValueExact<RequiredOptionalProps, undefined>>();
+  // @dts-jest:pass:snap
+  testType<keyof OmitByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
     // @dts-jest:pass:snap

From a73fbf014027324f92620d88271bcc21cb6b62fd Mon Sep 17 00:00:00 2001
From: Igor Kalinovskiy <jolly-good-fellow@yandex.ru>
Date: Sat, 9 Nov 2019 18:18:44 +1000
Subject: [PATCH 2/2] Fix (Pick|Omit)ByValue(Exact)? to not contain `undefined`
 in `keyof` of their result

---
 src/__snapshots__/mapped-types.spec.ts.snap | 40 ++++++++++-----------
 src/mapped-types.spec.snap.ts               | 40 ++++++++++-----------
 src/mapped-types.ts                         |  8 ++---
 3 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/src/__snapshots__/mapped-types.spec.ts.snap b/src/__snapshots__/mapped-types.spec.ts.snap
index 0a4268e..b8e2e49 100644
--- a/src/__snapshots__/mapped-types.spec.ts.snap
+++ b/src/__snapshots__/mapped-types.spec.ts.snap
@@ -139,25 +139,25 @@ exports[`Omit testType<Omit<Props, 'age'>>() (type) should match snapshot 1`] =
 
 exports[`Omit testType<Omit<T, 'age'>>() (type) should match snapshot 1`] = `"Pick<T, SetDifference<keyof T, \\"age\\">>"`;
 
-exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValue testType<OmitByValue<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValue testType<OmitByValue<T, string | boolean>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: T[Key] extends string | boolean ? never : Key; }[keyof T]>"`;
+exports[`OmitByValue testType<OmitByValue<T, string | boolean>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]-?: T[Key] extends string | boolean ? never : Key; }[keyof T]>"`;
 
-exports[`OmitByValue testType<keyof OmitByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined"`;
+exports[`OmitByValue testType<keyof OmitByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\""`;
 
-exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined>"`;
+exports[`OmitByValueExact testType<OmitByValueExact<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\" | \\"opt\\" | \\"optUndef\\">"`;
 
-exports[`OmitByValueExact testType<OmitByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>"`;
+exports[`OmitByValueExact testType<OmitByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]-?: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>"`;
 
-exports[`OmitByValueExact testType<keyof OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\" | undefined"`;
+exports[`OmitByValueExact testType<keyof OmitByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"reqUndef\\" | \\"opt\\" | \\"optUndef\\""`;
 
 exports[`Optional testType<Optional<Props, 'age' | 'visible'>>({ name: 'Yolo' }) (type) should match snapshot 1`] = `"Optional<Props, \\"age\\" | \\"visible\\">"`;
 
@@ -173,25 +173,25 @@ exports[`Overwrite const result: Overwrite<Omit<T, 'age'>, T> = rest (type) shou
 
 exports[`Overwrite testType<Overwrite<Props, NewProps>>() (type) should match snapshot 1`] = `"Pick<Pick<Props, \\"name\\" | \\"visible\\"> & Pick<NewProps, \\"age\\">, \\"name\\" | \\"age\\" | \\"visible\\">"`;
 
-exports[`PickByValue testType<PickByValue<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\" | undefined>"`;
+exports[`PickByValue testType<PickByValue<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | \\"reqUndef\\">"`;
 
-exports[`PickByValue testType<PickByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | undefined>"`;
+exports[`PickByValue testType<PickByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\">"`;
 
-exports[`PickByValue testType<PickByValue<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, undefined>"`;
+exports[`PickByValue testType<PickByValue<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, never>"`;
 
-exports[`PickByValue testType<PickByValue<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: T[Key] extends number ? Key : never; }[keyof T]>"`;
+exports[`PickByValue testType<PickByValue<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]-?: T[Key] extends number ? Key : never; }[keyof T]>"`;
 
-exports[`PickByValue testType<keyof PickByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\" | undefined"`;
+exports[`PickByValue testType<keyof PickByValue<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\""`;
 
-exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\" | undefined>"`;
+exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number | undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"reqUndef\\">"`;
 
-exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\" | undefined>"`;
+exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, \\"req\\">"`;
 
-exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, undefined>"`;
+exports[`PickByValueExact testType<PickByValueExact<RequiredOptionalProps, undefined>>() (type) should match snapshot 1`] = `"Pick<RequiredOptionalProps, never>"`;
 
-exports[`PickByValueExact testType<PickByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>"`;
+exports[`PickByValueExact testType<PickByValueExact<T, number>>() (type) should match snapshot 1`] = `"Pick<T, { [Key in keyof T]-?: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>"`;
 
-exports[`PickByValueExact testType<keyof PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\" | undefined"`;
+exports[`PickByValueExact testType<keyof PickByValueExact<RequiredOptionalProps, number>>() (type) should match snapshot 1`] = `"\\"req\\""`;
 
 exports[`PromiseType testType<PromiseType<Promise<string>>>() (type) should match snapshot 1`] = `"string"`;
 
diff --git a/src/mapped-types.spec.snap.ts b/src/mapped-types.spec.snap.ts
index 6e0aa20..a4397ac 100644
--- a/src/mapped-types.spec.snap.ts
+++ b/src/mapped-types.spec.snap.ts
@@ -142,34 +142,34 @@ type RequiredOptionalProps = {
 
 // @dts-jest:group PickByValue
 {
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req">
   testType<PickByValue<RequiredOptionalProps, number>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef">
   testType<PickByValue<RequiredOptionalProps, number | undefined>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, never>
   testType<PickByValue<RequiredOptionalProps, undefined>>();
-  // @dts-jest:pass:snap -> "req" | undefined
+  // @dts-jest:pass:snap -> "req"
   testType<keyof PickByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
-    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: T[Key] extends number ? Key : never; }[keyof T]>
+    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]-?: T[Key] extends number ? Key : never; }[keyof T]>
     testType<PickByValue<T, number>>();
   };
 }
 
 // @dts-jest:group PickByValueExact
 {
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req">
   testType<PickByValueExact<RequiredOptionalProps, number>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef">
   testType<PickByValueExact<RequiredOptionalProps, number | undefined>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, never>
   testType<PickByValueExact<RequiredOptionalProps, undefined>>();
-  // @dts-jest:pass:snap -> "req" | undefined
+  // @dts-jest:pass:snap -> "req"
   testType<keyof PickByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
-    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>
+    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]-?: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? Key : never : never; }[keyof T]>
     testType<PickByValueExact<T, number>>();
   };
 }
@@ -193,34 +193,34 @@ type RequiredOptionalProps = {
 
 // @dts-jest:group OmitByValue
 {
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef" | "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef" | "opt" | "optUndef">
   testType<OmitByValue<RequiredOptionalProps, number>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "opt" | "optUndef">
   testType<OmitByValue<RequiredOptionalProps, number | undefined>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef">
   testType<OmitByValue<RequiredOptionalProps, undefined>>();
-  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef" | undefined
+  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef"
   testType<keyof OmitByValue<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
-    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: T[Key] extends string | boolean ? never : Key; }[keyof T]>
+    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]-?: T[Key] extends string | boolean ? never : Key; }[keyof T]>
     testType<OmitByValue<T, string | boolean>>();
   };
 }
 
 // @dts-jest:group OmitByValueExact
 {
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef" | "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "reqUndef" | "opt" | "optUndef">
   testType<OmitByValueExact<RequiredOptionalProps, number>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "opt" | "optUndef">
   testType<OmitByValueExact<RequiredOptionalProps, number | undefined>>();
-  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef" | undefined>
+  // @dts-jest:pass:snap -> Pick<RequiredOptionalProps, "req" | "reqUndef" | "opt" | "optUndef">
   testType<OmitByValueExact<RequiredOptionalProps, undefined>>();
-  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef" | undefined
+  // @dts-jest:pass:snap -> "reqUndef" | "opt" | "optUndef"
   testType<keyof OmitByValueExact<RequiredOptionalProps, number>>();
 
   const fn = <T extends Props>(props: T) => {
-    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>
+    // @dts-jest:pass:snap -> Pick<T, { [Key in keyof T]-?: [number] extends [T[Key]] ? [T[Key]] extends [T[Key] & number] ? never : Key : Key; }[keyof T]>
     testType<OmitByValueExact<T, number>>();
   };
 }
diff --git a/src/mapped-types.ts b/src/mapped-types.ts
index 2acbe0d..54395d9 100644
--- a/src/mapped-types.ts
+++ b/src/mapped-types.ts
@@ -190,7 +190,7 @@ namespace Pick {}
  */
 export type PickByValue<T, ValueType> = Pick<
   T,
-  { [Key in keyof T]: T[Key] extends ValueType ? Key : never }[keyof T]
+  { [Key in keyof T]-?: T[Key] extends ValueType ? Key : never }[keyof T]
 >;
 
 /**
@@ -207,7 +207,7 @@ export type PickByValue<T, ValueType> = Pick<
 export type PickByValueExact<T, ValueType> = Pick<
   T,
   {
-    [Key in keyof T]: [ValueType] extends [T[Key]]
+    [Key in keyof T]-?: [ValueType] extends [T[Key]]
       ? [T[Key]] extends [ValueType]
         ? Key
         : never
@@ -240,7 +240,7 @@ export type Omit<T, K extends keyof any> = Pick<T, SetDifference<keyof T, K>>;
  */
 export type OmitByValue<T, ValueType> = Pick<
   T,
-  { [Key in keyof T]: T[Key] extends ValueType ? never : Key }[keyof T]
+  { [Key in keyof T]-?: T[Key] extends ValueType ? never : Key }[keyof T]
 >;
 
 /**
@@ -257,7 +257,7 @@ export type OmitByValue<T, ValueType> = Pick<
 export type OmitByValueExact<T, ValueType> = Pick<
   T,
   {
-    [Key in keyof T]: [ValueType] extends [T[Key]]
+    [Key in keyof T]-?: [ValueType] extends [T[Key]]
       ? [T[Key]] extends [ValueType]
         ? never
         : Key