Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of React Hot Loader 3 breaks async functions #23

Closed
JeffreyATW opened this issue Dec 12, 2016 · 2 comments
Closed

Use of React Hot Loader 3 breaks async functions #23

JeffreyATW opened this issue Dec 12, 2016 · 2 comments

Comments

@JeffreyATW
Copy link

I upgraded pui-react-tools from 2.0.2 to 2.0.3, but the slight change from RHL 1 to 3 caused my async functions to stop working.

Under the hood, this bug is at fault: gaearon/react-hot-loader#391

I would recommend reverting, not to 1.3.0, but to 1.3.1, which solves the ReactMount issue that was the reason pui-react-tools upgraded to RHL 3 in the first place.

@charleshansen
Copy link
Contributor

Thanks for the detailed fix suggestion. Yeah, the hot loader broke. There is a better fix using the react-hot-loader babel plugin, but it involves changing code not under the control of pui-react-tools. I'll try to find a way to get that in, but if that takes too long, I'll at least try your 1.3.1 lock.

@rdy
Copy link
Contributor

rdy commented Dec 17, 2016

I will generate a new version that downgrades the hot module loader for a version 2, but we're probably going to move forward with the newer hot module loader (beta 3) in a major rev since it is so different. At the time we were forced to upgrade because there wasn't a clear fix and it was breaking multiple projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants