Remove the public key #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhanghp
reviewed
Jun 4, 2020
lib/plaidRequest.js
Outdated
| @@ -90,6 +90,7 @@ var plaidRequest = function(context, requestSpec, clientRequestOptions, cb) { | |||
| responseType: requestSpec.binary ? 'arrayBuffer' : 'json' | |||
| }, clientRequestOptions); | |||
|
|
|||
|
|
|||
davidzhanghp
approved these changes
Jun 4, 2020
davidzhanghp
suggested changes
Jun 4, 2020
|
@davidzhanghp Right now, the lib will throw an error if the third param is not I can also add a check for if the number of parameters is longer than what we expect. |
|
@otherchen to change this to use an object parameter |
anjiren
approved these changes
Jun 30, 2020
otherchen
force-pushed
the
ac-remove-public-key
branch
from
6581968 to
69d3589
Compare
davidzhanghp
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints in this lib have been updated to accept client_id/secret instead of the public_key.
This PR also consolidates the parameters for the
plaid.Clientcall into an object so that if we make changes to the parameter list at a later point, it will be much easier to manage.