Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic after WKT commit: assignment to entry in nil map #102

Closed
coxley opened this issue Oct 3, 2023 · 2 comments
Closed

Panic after WKT commit: assignment to entry in nil map #102

coxley opened this issue Oct 3, 2023 · 2 comments

Comments

@coxley
Copy link
Contributor

coxley commented Oct 3, 2023

Using the commit from #99: go install github.com/planetscale/vtprotobuf/cmd/protoc-gen-go-vtproto@d49cd97

Nothing special about the parameters seem to change it:

protoc -Iprotos/protobuf \
  --go-vtproto_out=paths=source_relative,<omitted module rewrites>:gen \
  --go-vtproto_opt=features=marshal+unmarshal+size+pool+clone \
  <protos>
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/planetscale/vtprotobuf/generator.(*ObjectSet).Set(0x72bfa0?, {0xc00015c650?, 0xc00015c64b?})
 /root/go/pkg/mod/github.com/planetscale/[email protected]/generator/generator.go:43 +0x109
flag.(*FlagSet).Set(0xc0000665a0, {0xc00015c64b, 0x4}, {0xc00015c650, 0x54})
 /usr/lib/go-1.19/src/flag/flag.go:488 +0x78
google.golang.org/protobuf/compiler/protogen.Options.New({0xc000022640?, 0x0?}, 0xc000112cb0)
 /root/go/pkg/mod/google.golang.org/[email protected]/compiler/protogen/protogen.go:206 +0x138d
google.golang.org/protobuf/compiler/protogen.run({0xc000022640?, 0x0?}, 0xc000055f58)
 /root/go/pkg/mod/google.golang.org/[email protected]/compiler/protogen/protogen.go:70 +0x125
google.golang.org/protobuf/compiler/protogen.Options.Run({0xc000022640?, 0x0?}, 0xc000022630?)
 /root/go/pkg/mod/google.golang.org/[email protected]/compiler/protogen/protogen.go:52 +0x2a
main.main()
 /root/go/pkg/mod/github.com/planetscale/[email protected]/cmd/protoc-gen-go-vtproto/main.go:30 +0x1fa
--go-vtproto_out: protoc-gen-go-vtproto: Plugin failed with status code 2.
@vmg
Copy link
Member

vmg commented Oct 3, 2023

My bad. Can you try pulling main again? :)

@vmg vmg closed this as completed Oct 3, 2023
@coxley
Copy link
Contributor Author

coxley commented Oct 3, 2023

@vmg So fast — fixed. :)

typing-typing-fast-gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants