Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated field with nulls break pool #73

Closed
delaneyj opened this issue Jan 4, 2023 · 2 comments · Fixed by #96
Closed

Repeated field with nulls break pool #73

delaneyj opened this issue Jan 4, 2023 · 2 comments · Fixed by #96

Comments

@delaneyj
Copy link

delaneyj commented Jan 4, 2023 •
edited
Loading

It appears there is no null checks for repeated field with returning to the pool, causing panic. Is this not supported or am I missing how to handle properly?
@fly3366
Copy link

fly3366 commented Apr 21, 2023

lgtm, such as Reset, it's not check null for range op.

@fly3366
Copy link

fly3366 commented Apr 21, 2023

sorry, range nil was ok. but why repeated flied not return to pool when its parent was return?

@kruskall kruskall mentioned this issue Sep 14, 2023
Merged
@vmg vmg closed this as completed in #96 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not try to reset nil objects
2 participants
@delaneyj @fly3366