Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web -> locations -> /wp/wp-content/uploads doesn't have expires #75

Open
cborup opened this issue Aug 16, 2022 · 3 comments
Open

web -> locations -> /wp/wp-content/uploads doesn't have expires #75

cborup opened this issue Aug 16, 2022 · 3 comments

Comments

@cborup
Copy link

cborup commented Aug 16, 2022

In .platform.app.yaml
web:
locations:
"/wp/wp-content/uploads"

Doesn't have expires, making it default to -1.
In a setting with varnish (in our case Fastly) in front of WordPress this leads to much needless trafic to the backend server

@chadwcarlson
Copy link
Contributor

cc @gilzow

@gilzow
Copy link
Contributor

gilzow commented Aug 18, 2022

@cborup we haven't historically added caching to the uploads directory, leaving that to the end user/developer to add if/when they choose to implement caching. HOWEVER, I think we should, and then add a note that it's enabled in our docs.

Please see the most recent PR here, and let us know if this will address your concern/request.

@cborup
Copy link
Author

cborup commented Aug 19, 2022

Thanks @gilzow this would indeed have solved our problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants