Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table for mount:size unclear for mutliple mounts, single volume #1155

Open
CollierCZ opened this issue Sep 1, 2022 · 2 comments
Open

Table for mount:size unclear for mutliple mounts, single volume #1155

CollierCZ opened this issue Sep 1, 2022 · 2 comments

Comments

@CollierCZ
Copy link
Contributor

Based on some confusion I saw from others recently, it seems the table returned for the command mount:size is unclear. For example, this table is returned for three mounts on on volume:

+----------+-----------+---------+-----------+-----------+--------+
| Mount(s) | Size(s)   | Disk    | Used      | Available | % Used |
+----------+-----------+---------+-----------+-----------+--------+
| data     | 4.1 MiB   | 1.9 GiB | 238.1 MiB | 1.7 GiB   | 12.2%  |
| data.ms  | 221.4 MiB |         |           |           |        |
| output   | 6.6 MiB   |         |           |           |        |
+----------+-----------+---------+-----------+-----------+--------+

At first glance, this appears to be a table, which would mean the items in the first row only apply to that row. But really, it's about the disk that applies to all items in that row.

It seems easy enough to split them into two tables, like so:

+---------+-----------+
| Mount   | Size      |
+---------+-----------+
| data    | 4.1 MiB   |
| data.ms | 221.4 MiB |
| output  | 6.6 MiB   |
+---------+-----------+
+---------+-----------+-----------+--------+
| Disk    | Used      | Available | % Used |
+---------+-----------+-----------+--------+
| 1.9 GiB | 238.1 MiB | 1.7 GiB   | 12.2%  |
+---------+-----------+-----------+--------+

That's more accurate. But it doesn't work well when there are multiple volumes and the information is actually tabular. So I don't know what the solution should be, but ideally, it shouldn't be like the table in the first example.

@pjcdawkins
Copy link
Collaborator

pjcdawkins commented Sep 4, 2022

Yes it's little a bit unfortunate.

There is a note under it saying "All the mounts share the same disk" - here's the current output for a Drupal site:

Checking disk usage for all mounts on [email protected]...

+-------------------------+-----------+---------+---------+-----------+--------+
| Mount(s)                | Size(s)   | Disk    | Used    | Available | % Used |
+-------------------------+-----------+---------+---------+-----------+--------+
| .console                | 4 KiB     | 3.9 GiB | 1.8 GiB | 2.1 GiB   | 45.6%  |
| .drush                  | 740 KiB   |         |         |           |        |
| drush-backups           | 25.9 MiB  |         |         |           |        |
| private                 | 1.2 GiB   |         |         |           |        |
| tmp                     | 12 KiB    |         |         |           |        |
| web/sites/default/files | 536.6 MiB |         |         |           |        |
+-------------------------+-----------+---------+---------+-----------+--------+

All the mounts share the same disk.

To increase the available space, edit the disk key in the .platform.app.yaml file.

I wonder if this is a simpler/lazier solution:

+-------------------------+-----------+---------+-----------+--------+
| Mount                   | Used      | Total   | Available | % Used |
+-------------------------+-----------+---------+-----------+--------+
| .console                | 4 KiB     |         |           |        |
| .drush                  | 740 KiB   |         |           |        |
| drush-backups           | 25.9 MiB  |         |           |        |
| private                 | 1.2 GiB   |         |           |        |
| tmp                     | 12 KiB    |         |           |        |
| web/sites/default/files | 536.6 MiB |         |           |        |
+-------------------------+-----------+---------+-----------+--------+
| Disk for the above      | 1.8 GiB   | 3.9 GiB | 2.1 GiB   | 45.6%  |
+-------------------------+-----------+---------+-----------+--------+

But maybe that's a breaking change.

The upcoming disk command (see GitLab) is a totally different way of reading the disk usage for an app.

@CollierCZ
Copy link
Contributor Author

I like the simple solution. But the upcoming disk command does seem to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants