Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support baseVertex for GPURenderPassEncoder #6751

Open
AlexAPPi opened this issue Jun 25, 2024 · 6 comments · May be fixed by #6978
Open

Add support baseVertex for GPURenderPassEncoder #6751

AlexAPPi opened this issue Jun 25, 2024 · 6 comments · May be fixed by #6978
Assignees
@mvaligursky
Labels
area: graphics Graphics related issue enhancement

Comments

@AlexAPPi
Copy link
Contributor

AlexAPPi commented Jun 25, 2024 •
edited
Loading

Hi!

It would be nice to have baseVertex support for the mesh.

https://developer.mozilla.org/en-US/docs/Web/API/GPURenderPassEncoder/drawIndexed

engine/src/platform/graphics/webgpu/webgpu-graphics-device.js

Line 521 in 03920de

passEncoder.drawIndexed(primitive.count, numInstances, primitive.base, 0, 0);

engine/src/scene/mesh.js

Line 256 in 03920de

this.primitive = [{

@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jun 26, 2024
@mvaligursky mvaligursky self-assigned this Jun 26, 2024
@mvaligursky
Copy link
Contributor

mvaligursky commented Jun 27, 2024 •
edited
Loading

WebGL 2 adds support for this using WEBGL_draw_instanced_base_vertex_base_instance but its support seems to be very low (less than 1%) here https://web3dsurvey.com/webgl2

@AlexAPPi
Copy link
Contributor Author

AlexAPPi commented Jun 27, 2024 •
edited
Loading

WebGL 2 adds support for this using WEBGL_draw_instanced_base_vertex_base_instance but its support seems to be very low (less than 1%) here https://web3dsurvey.com/webgl2

If you focus on chromium-like browsers, they have support; this greatly speeds up the work with indexes, for example for the LOD system.

@mvaligursky
Copy link
Contributor

I see this:

Screenshot 2024-06-27 at 12 31 56

My MacOS on latest Chrome does not expose this extension.

What data do you see?

@AlexAPPi
Copy link
Contributor Author

Sorry, I'm talking about webGPU support.

https://developer.mozilla.org/en-US/docs/Web/API/GPURenderBundleEncoder/drawIndexed#browser_compatibility

@AlexAPPi
Copy link
Contributor Author

Closed #6977

@mvaligursky
Copy link
Contributor

this needs to stay open till the implementation is merged in.

@mvaligursky mvaligursky reopened this Sep 20, 2024
@mvaligursky mvaligursky linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation of baseVertex support AlexAPPi/engine
2 participants
@AlexAPPi @mvaligursky