Fix flake8 plugins #762
Fix flake8 plugins #762
Conversation
|
@tisto thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@buchi @lukasgraf the way black formats imports is incompatible with isort it seems: PyCQA/isort#694 cc @gforcada |
| @@ -100,6 +100,9 @@ recipe = plone.recipe.codeanalysis | |||
| directory = ${buildout:directory}/src | |||
| flake8-exclude=bootstrap.py,bootstrap-buildout.py,docs,bin,*.egg,setup.py,overrides | |||
| flake8-max-complexity = 25 | |||
| # flake8-ignore = E203, E266, E501, W503 | |||
There was a problem hiding this comment.
Would you mind telling the motivation of removing the .flake8 file to just commiting a comment here in a base.cfg?
We're following black adoption in plone core to make a well thought decision on how to use in internal packages, but we got confused about this commit.
No description provided.